Portability: char type with gcc on ARM defaults to unsigned
The char type with gcc on ARM defaults to unsigned instead of signed on x86. Consequently the VideoHardwareDecoder flag is not working as intended on ARM (result is a black screen with MPEG2/VDPAU).
Adding -fsigned-char to CXXFLAGS and CFLAGS in the Makefile resolves the problem.
Thank you for your work.
#2 Updated by SPAM over 6 years ago
This is mostly fixed in current git, but I believe there's one more of these changes still needed:
diff --git a/softhddev.c b/softhddev.c index a44f020..99bbb76 100644 --- a/softhddev.c +++ b/softhddev.c @@ -95 +95 @@ static const char *X11ServerArguments; ///< default command arguments -static char ConfigStillDecoder; ///< hw/sw decoder for still picture +static signed char ConfigStillDecoder; ///< hw/sw decoder for still picture