Project

General

Profile

Bug #1916

Portability: char type with gcc on ARM defaults to unsigned

Added by Anonymous almost 7 years ago. Updated over 6 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Start date:
09/28/2014
Due date:
% Done:

0%


Description

The char type with gcc on ARM defaults to unsigned instead of signed on x86. Consequently the VideoHardwareDecoder flag is not working as intended on ARM (result is a black screen with MPEG2/VDPAU).
Adding -fsigned-char to CXXFLAGS and CFLAGS in the Makefile resolves the problem.

Thank you for your work.

History

#1 Updated by rell almost 7 years ago

This path should eleminate the type-limits compiler warnings and solve the arm unsigned char issue.

http://pastebin.com/1zWCxFr8

#2 Updated by SPAM over 6 years ago

This is mostly fixed in current git, but I believe there's one more of these changes still needed:

diff --git a/softhddev.c b/softhddev.c
index a44f020..99bbb76 100644
--- a/softhddev.c
+++ b/softhddev.c
@@ -95 +95 @@ static const char *X11ServerArguments;    ///< default command arguments
-static char ConfigStillDecoder;        ///< hw/sw decoder for still picture
+static signed char ConfigStillDecoder;    ///< hw/sw decoder for still picture

Also available in: Atom PDF